Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add documentation for $pattern annotation #627

Merged
merged 3 commits into from
Jun 24, 2024
Merged

Conversation

jonassobotta
Copy link
Contributor

This adds documentation for the new annotation $pattern in SAP/abap-file-formats-tools#312

Fixes #626

@Markus1812 Markus1812 added the documentation Improvements or additions to documentation label Jun 21, 2024
Copy link
Contributor

@albertmink albertmink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found a typo. And why don't you put the new section in between Length Specification and Mutliple Of? Right now, it has been added just in the middle of section Enum Values.

docs/json.md Outdated Show resolved Hide resolved
Copy link
Contributor

@albertmink albertmink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

@jonassobotta jonassobotta merged commit e5ef126 into main Jun 24, 2024
9 checks passed
@jonassobotta jonassobotta deleted the docu/regexPatterns branch June 24, 2024 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add doc for $pattern
3 participants