Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support build-artifact-name in module build parameters #426

Merged
merged 8 commits into from
Jun 24, 2019
Merged

Support build-artifact-name in module build parameters #426

merged 8 commits into from
Jun 24, 2019

Conversation

tal-sapan
Copy link
Contributor

@tal-sapan tal-sapan commented Jun 23, 2019 •
edited
Loading

Before submitting a pull request, Please make sure the following:

Description

Please explain the changes you made.

Link to design (if applicable)

Checklist

  • Code compiles correctly
  • Relevant tests were added (unit / contract / integration)
  • Relevant logs were added
  • Formatting and linting run locally successfully
  • All tests passing
  • UA review
  • Design is documented
  • Extended the README / documentation, if necessary
  • Open source is approved

@tal-sapan tal-sapan requested a review from ShimiT as a code owner June 23, 2019 12:22
allaVolkov
allaVolkov suggested changes Jun 23, 2019
View reviewed changes
internal/artifacts/manifest.go Outdated Show resolved Hide resolved
internal/artifacts/module_arch.go Outdated Show resolved Hide resolved
internal/artifacts/manifest.go Outdated Show resolved Hide resolved
internal/artifacts/manifest.go Outdated
@@ -193,31 +193,52 @@ func getResourcePath(resource *mta.Resource) string {

func getModulePath(module *mta.Module, targetPathGetter dir.ITargetPath, defaultBuildResult string) (string, error) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please rename to getModuleArtifactPath

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

internal/artifacts/manifest.go Outdated Show resolved Hide resolved
@tal-sapan
CR fixes
ff71aac 
- Check build-artifact-name is really a string
- Remove unnecessary filepath.Join
- Remove unnecessary pathSep constant
@tal-sapan
Error message when build-artifact-name is not a string
2e10bd6
@allaVolkov allaVolkov merged commit e67fa55 into master Jun 24, 2019
@tal-sapan tal-sapan deleted the build_artifact_name branch June 24, 2019 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@allaVolkov allaVolkov allaVolkov requested changes

@ShimiT ShimiT Awaiting requested review from ShimiT

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tal-sapan @allaVolkov