Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prevent panic in from context function #110

Merged
merged 2 commits into from
Feb 15, 2024
Merged

prevent panic in from context function #110

merged 2 commits into from
Feb 15, 2024

Conversation

hebelal
Copy link
Contributor

@hebelal hebelal commented Feb 13, 2024

No description provided.

@hebelal hebelal requested a review from a team as a code owner February 13, 2024 10:56
liga-oz
liga-oz previously approved these changes Feb 13, 2024
View reviewed changes
Copy link
Contributor

@liga-oz liga-oz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

apart from the logic in the if statement from sample lgtm 👍🏻

sample/middleware.go Outdated Show resolved Hide resolved
@hebelal hebelal requested a review from liga-oz February 14, 2024 09:17
@hebelal hebelal merged commit 76f22d8 into master Feb 15, 2024
10 checks passed
@hebelal hebelal deleted the fix-from-context branch February 15, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liga-oz liga-oz liga-oz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hebelal @liga-oz @hebelsan