Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor components #14

Closed
mikerodonnell89 opened this issue May 31, 2018 · 2 comments
Closed

Refactor components #14

mikerodonnell89 opened this issue May 31, 2018 · 2 comments

Comments

@mikerodonnell89
Copy link
Member

I'd prefer to use external html and scss so that we have a cleaner code base.

I'd also perfer to stick to naming conventions so it's easier to find files in the workspace, i.e.:

  • alert.component.ts
  • alert.component.html
  • alert.component.scss

Using the Component postfix for components will also help to better separate out components and other entities, such as interfaces. If you like to create an interface for a component, you'd like to reserve the entity name (i.e. Pagination) for the interface, where as the component should have a more specific name (i.e. PaginationComponent).

@tobi-or-not-tobi
Copy link

@mikerodonnell89 next time you might want to make a reference from your PR to this ticket, that will help the community to understand the changes which where made for this ticket.

@mikerodonnell89
Copy link
Member Author

#14

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants