fix(core, platform): add fix for breadcrumb template not being rendered in Dynamic Page component #11677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for fundamental-ngx ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Visit the preview URL for this PR (updated for commit 33691ed): https://fundamental-ngx-gh--pr11677-fix-dynamic-page-bre-4b98imog.web.app (expires Sun, 07 Apr 2024 20:50:07 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 41b993ee8e451bd7c6770b342ce142dc886eacff |
InnaAtanasova
force-pushed
the
fix/dynamic-page-breadcrumb-ng15
branch
2 times, most recently
from
d535cd2
to
c67e7f5
Compare
InnaAtanasova
changed the title
droshev
approved these changes
Apr 3, 2024
InnaAtanasova
force-pushed
the
fix/dynamic-page-breadcrumb-ng15
branch
3 times, most recently
from
505a0cc
to
d9f3bee
Compare
…Dynamic Page component
InnaAtanasova
force-pushed
the
fix/dynamic-page-breadcrumb-ng15
branch
from
d9f3bee
to
0ec9c04
Compare
mikerodonnell89
approved these changes
Apr 4, 2024
InnaAtanasova
force-pushed
the
fix/dynamic-page-breadcrumb-ng15
branch
from
70cd856
to
33691ed
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue(s)
closes #11613
Description
The problem was that the screenreader was reading "breadcrumb" word when no breadcrumb was displayed. It was because of 2 reasons: