Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): relative position property for Dynamic Page #11678

Merged
merged 1 commit into from
Apr 3, 2024

Conversation

InnaAtanasova
Copy link
Contributor

Related Issue(s)

closes #11640

Description

The floating footer of Dynamic page occupies the entire width of the page. When Dynamic page is placed inside Flexible Column Layout the footer needs to span within the column that Dynamic page occupies. For this to work we need to set the position of Dynamic page to relative. I added an input property that could allow this

Screenshots

Before:

Screenshot 2024-04-01 at 3 15 57 PM

After:

Screenshot 2024-04-01 at 2 35 23 PM

Copy link

github-actions bot commented Apr 1, 2024

Visit the preview URL for this PR (updated for commit 38a9dc6):

https://fundamental-ngx-gh--pr11678-fix-dynamic-page-rel-me091e0i.web.app

(expires Thu, 04 Apr 2024 19:20:20 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 41b993ee8e451bd7c6770b342ce142dc886eacff

Copy link

netlify bot commented Apr 1, 2024

Deploy Preview for fundamental-ngx ready!

Name Link
🔨 Latest commit 38a9dc6
🔍 Latest deploy log https://app.netlify.com/sites/fundamental-ngx/deploys/660b088cfe70a20008b19be9
😎 Deploy Preview https://deploy-preview-11678--fundamental-ngx.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@mikerodonnell89 mikerodonnell89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well - but I wonder if this is something that we can handle via ContentChildren without needing the developer to add an input

@InnaAtanasova
Copy link
Contributor Author

InnaAtanasova commented Apr 2, 2024

Works well - but I wonder if this is something that we can handle via ContentChildren without needing the developer to add an input

Open to hear your ideas. Dynamic Page can be placed in so many different containers, with scrolling, without scrolling, flexible column layout, etc. We also need to take into account all the existing apps already using Dynamic Page. In my opinion adding position relative can mess up a lot of things.

@droshev droshev merged commit ea5631d into main Apr 3, 2024
18 of 19 checks passed
@droshev droshev deleted the fix/dynamic-page-relative-position branch April 3, 2024 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Floating Footer in Flexible Column Layout
3 participants