feat(platform): add datasource loading events #7671
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue(s)
closes #7581
Description
Updated all pre-defined dataSources by adding
onDataRequested()
,onDataReceived()
andisDataLoading
methods/props.These methods are now exposed as outputs by platform components, that use DataSource:
Additionally, complex components as table, upload collection, value help dialog and approval flow are now able to display loading state without a need to be managed externally (by relying on the methods from dataSource directly)
Screenshots
Before:
After:
Please check whether the PR fulfills the following requirements
During Implementation
PR Quality
https://github.com/SAP/fundamental-ngx/blob/main/CONTRIBUTING.md
https://github.com/SAP/fundamental-ngx/wiki/PR-Review-Checklist
README.md