Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(platform): add datasource loading events #7671

Merged
merged 2 commits into from
Feb 7, 2022

Conversation

dmitry-stepanenko
Copy link
Contributor

Related Issue(s)

closes #7581

Description

Updated all pre-defined dataSources by adding onDataRequested(), onDataReceived() and isDataLoading methods/props.

These methods are now exposed as outputs by platform components, that use DataSource:

  • approval flow
  • combobox
  • multi-combobox
  • multi-input
  • table
  • value-help-dialog
  • upload-collection

Additionally, complex components as table, upload collection, value help dialog and approval flow are now able to display loading state without a need to be managed externally (by relying on the methods from dataSource directly)

Screenshots

Before:

After:

Please check whether the PR fulfills the following requirements

During Implementation
  1. Visual Testing:
  • visual misalignments/updates
  • check Light/Dark/HCB/HCW themes
  • RTL/LTR - proper rendering and labeling
  • responsiveness(resize)
  • Content Density (Cozy/Compact/(Condensed))
  • States - hover/disabled/focused/active/on click/selected/selected hover/press state
  • Interaction/Animation - open/close, expand/collapse, add/remove, check/uncheck
  • Mouse vs. Keyboard support
  • Text Truncation
  1. API and functional correctness
  • check for console logs (warnings, errors)
  • API boundary values
  • [n/a] different combinations of components - free style
  • change the API values during testing
  1. Documentation and Example validations
  • missing API documentation or it is not understandable
  • poor examples
  • Stackblitz works for all examples
  1. Accessibility testing
  2. Browser Testing - Edge, Safari, Chrome, Firefox
PR Quality

@netlify
Copy link

netlify bot commented Feb 3, 2022

✔️ Deploy Preview for fundamental-ngx ready!

🔨 Explore the source changes: 16a0c26

🔍 Inspect the deploy log: https://app.netlify.com/sites/fundamental-ngx/deploys/62012efed5046e00077a1ff5

😎 Browse the preview: https://deploy-preview-7671--fundamental-ngx.netlify.app

@dmitry-stepanenko dmitry-stepanenko force-pushed the ds/7581-datasource-loading-events branch 2 times, most recently from d11aaf4 to 17bc0e7 Compare February 4, 2022 16:56
@github-actions
Copy link

github-actions bot commented Feb 7, 2022

This pull request is stale because it has been open 2 days with no activity. Remove stale label or comment or this will be closed in 3 days

@github-actions github-actions bot added the stale label Feb 7, 2022
@dmitry-stepanenko dmitry-stepanenko force-pushed the ds/7581-datasource-loading-events branch 3 times, most recently from 2f5e639 to ca92c70 Compare February 7, 2022 12:48
@dmitry-stepanenko dmitry-stepanenko merged commit 7a19de2 into main Feb 7, 2022
@dmitry-stepanenko dmitry-stepanenko deleted the ds/7581-datasource-loading-events branch February 7, 2022 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feat: Extends DataSource based component for data events
4 participants