Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: checkbox a11y #1116

Merged
merged 5 commits into from
Jul 1, 2020
Merged

fix: checkbox a11y #1116

merged 5 commits into from
Jul 1, 2020

Conversation

jacobdevera
Copy link
Contributor

@jacobdevera jacobdevera commented Jul 1, 2020 •
edited
Loading

Description

  • aria-checked is unneeded on a native input type="checkbox" and was not properly reflecting the state of the checkbox
  • checked and defaultChecked should be set independently
  • MultiInput was changing Checkbox ids on every render

Out of Scope:

@jacobdevera jacobdevera added the A11y Accessiblity label Jul 1, 2020
@jacobdevera jacobdevera self-assigned this Jul 1, 2020
@netlify
Copy link

netlify bot commented Jul 1, 2020 •
edited
Loading

Deploy preview for fundamental-react ready!

Built with commit fbda5d3

https://deploy-preview-1116--fundamental-react.netlify.app

@jacobdevera jacobdevera merged commit b6fad78 into master Jul 1, 2020
@jacobdevera jacobdevera deleted the fix/checkbox branch July 1, 2020 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbadan jbadan jbadan approved these changes

Assignees

@jacobdevera jacobdevera

Labels
A11y Accessiblity
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jacobdevera @jbadan