feat: Publish the package with a lib directory #1119
Conversation
|
Deploy preview for fundamental-react ready! Built with commit 8fc5521 |
skvale
force-pushed
the
feat/publish-package-with-lib-dir
branch
from
896feba
to
9240a9d
Compare
| @@ -11,7 +11,7 @@ const Import = () => { | |||
| customStyle={{ padding: 10, whiteSpace: 'pre-wrap', fontSize: 14 }} | |||
| language='javascript' | |||
| style={googlecode}> | |||
| {`import { ${groups[groups.length - 1]} } from 'fundamental-react/${groups[1]}';`} | |||
There was a problem hiding this comment.
So this isn't your fault, but I just noticed:
import { ButtonSegmented } from 'fundamental-react/lib/ButtonSegmented'; is not correct, it should be import { ButtonSegmented } from 'fundamental-react/lib/Button';
This works for forms because they're inside of a folder in storybook. So we can either make this import component smarter or fix Button to be under a folder by changing https://github.com/SAP/fundamental-react/blob/master/src/Button/__stories__/ButtonSegmented.stories.js#L7 to title: 'Component API/Button/ButtonSegmented' and the same for Button.
I don't think there's any other components that share a folder
There was a problem hiding this comment.
import { TabGroup } from 'fundamental-react/lib/TabGroup';
should be
import { TabGroup } from 'fundamental-react/lib/Tabs';
|
Just to confirm, I should include |
|
@skvale Yeah - the only repo where you can't yet is fundamental-styles (confusing I know) |
Description
This helps consumers
npm linkthe repo locally.BREAKING CHANGE: All imports from subdirectories will need to include the
libin their path now.