Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: prevent disabled and readonly select from opening #1124

Merged
merged 3 commits into from
Jul 15, 2020
Merged

fix: prevent disabled and readonly select from opening #1124

merged 3 commits into from
Jul 15, 2020

Conversation

jacobdevera
Copy link
Contributor

Description

  • disable Popover triggers on disabled and readonly Select
  • move onClick to right component

@jacobdevera jacobdevera self-assigned this Jul 15, 2020
@netlify
Copy link

netlify bot commented Jul 15, 2020

Deploy preview for fundamental-react ready!

Built with commit a94e3c0

https://deploy-preview-1124--fundamental-react.netlify.app

@jacobdevera jacobdevera requested a review from a team July 15, 2020 16:16
meganaconley
meganaconley approved these changes Jul 15, 2020
View reviewed changes
Copy link
Contributor

@meganaconley meganaconley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One q - should we not be able to tab to the disabled Select? It's correctly announced as dimmed if made tabbable. Otherwise code/behavior looks good.

@jacobdevera
Copy link
Contributor Author

The Fiori spec states to make them non-focusable: https://experience.sap.com/fiori-design-web/ui-element-states/#disabled

@jacobdevera jacobdevera merged commit 7d64334 into master Jul 15, 2020
@jacobdevera jacobdevera deleted the fix/disabled-readonly-select branch July 15, 2020 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meganaconley meganaconley meganaconley approved these changes

Assignees

@jacobdevera jacobdevera

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jacobdevera @meganaconley