feat: add textClassName prop and unit test #1184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for fundamental-react ready! Built with commit 11c3c9f |
skvale
reviewed
Aug 26, 2020
src/Forms/Checkbox.test.js
Outdated
| @@ -119,6 +119,16 @@ describe('<Checkbox />', () => { | |||
| ).toContain('wonderful-styles'); | |||
| }); | |||
|
|
|||
| test('should set validationClassName on the popover', () => { | |||
There was a problem hiding this comment.
should set childrenClassName on the checkbox children
There was a problem hiding this comment.
Oh that is super weird. I was sure I changed the title of this test, thanks!
jbadan
reviewed
Aug 26, 2020
src/Forms/Checkbox.js
Outdated
| @@ -119,6 +125,8 @@ Please ensure you are either using a visible \`FormLabel\` or an \`aria-label\` | |||
| ); | |||
| } | |||
| }, | |||
| /** Additional classes to apply to children */ | |||
| childrenClassName: PropTypes.string, | |||
There was a problem hiding this comment.
I think we have to be a little more careful with the name here - if the child is not a string, it won't add this class. Do we want that? Do we not? I don't know...
There was a problem hiding this comment.
I also thought perhaps this was not the best name. Would you have a suggestion of a more semantic, or explicit name? Perhaps stringChildrenClassName?
There was a problem hiding this comment.
I think textClassName would be fine
Mike-Diaz
changed the title
jbadan
approved these changes
Sep 2, 2020
jacobdevera
approved these changes
Sep 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds the
textClassNameprop inside ofCheckboxin order for custom classes to be applied to the element. This is necessary for styles to target the class name and be applied directly to the children. This does not change the way the component originally works since the standard class will always be applied.Linked to PR: https://github.concur.com/coreui/nui-widgets-lab/pull/124
Added Unit tests