Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: in SSR null is not a valid prop-type #1198

Merged
merged 1 commit into from
Sep 4, 2020
Merged

fix: in SSR null is not a valid prop-type #1198

merged 1 commit into from
Sep 4, 2020

Conversation

skvale
Copy link
Contributor

@skvale skvale commented Sep 4, 2020

Description

Consumers are seeing this warning if running code containing the DatePicker for SSR

Warning: Failed prop type: Popper: prop type `flipContainer` is invalid; it must be a function, usually from the `prop-types` package, but received `object`.
     in Popper
     in Popover
     in div
     in DatePicker

fixes #issueid

@skvale skvale self-assigned this Sep 4, 2020
@netlify
Copy link

netlify bot commented Sep 4, 2020

Deploy preview for fundamental-react ready!

Built with commit c0af191

https://deploy-preview-1198--fundamental-react.netlify.app

@skvale skvale merged commit 7d614db into master Sep 4, 2020
@skvale skvale deleted the fix/custom-prop-types-cannot-return-null branch September 4, 2020 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbadan jbadan jbadan approved these changes

Assignees

@skvale skvale

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@skvale @jbadan @sam-kvale-sap