feat: cell-level keyboard navigation for Table #1211
Merged
+1,684
−69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for fundamental-react ready! Built with commit f65aedd |
Mike-Diaz
reviewed
Sep 18, 2020
src/Table/Table.js
Outdated
| className={tableClasses} | ||
| ref={tableRef} | ||
| role={keyboardNavigation ? 'grid' : 'table'}> | ||
| <caption aria-live='polite' className='fd-table__instructions' |
There was a problem hiding this comment.
Is __instructions intentional? In fd-styles the class for <caption> appears as fd-table__caption. Currently the text is visible when traversing through the cells.
There was a problem hiding this comment.
I decided to change it to __caption in the end, but didn't put that change here yet. Thanks for catching that.
This reverts commit 262b97d.
…/table-navigation
prsdthkr
requested changes
Sep 22, 2020
Mike-Diaz
approved these changes
Sep 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Pending update of
fundamental-stylesto incorporate this PR SAP/fundamental-styles#1661 to hide screen reader instructionsEnterto toggle 'edit mode': in edit mode, all tabbable fields can be navigated to with the Tab keyEscto exit edit modecompact,condensed,keyboardNavigation, andlocalizedTextpropsaria-liveregion for announcing table statusOut of Scope / Known Issues (to be created)
Selectshould be full-width in cells (likely requires prop passing by putting into aFormGroupto apply full-width styling)DatePickerpopover when opened from a cell appears to gradually shift off-screen when changing months; this doesn't happen with the DatePicker alone