fix: fix isCssModulesEnabled check when styles is undefined and improve setup in README #1237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for fundamental-react ready! Built with commit 97a993e |
prsdthkr
approved these changes
Oct 8, 2020
jbadan
approved these changes
Oct 8, 2020
|
why are my builds hanging forever |
|
Yep, this seems to be happening a lot recently. I've restarted the build. |
|
Eeeeshhh 🙄 |
|
I think moving to travis.com will reduce build times. |
|
@prsdthkr For a little bit, but once everyone moves over after .org is no longer supported it will be even worse. |
|
@droshev pointed this out 🤯 |
|
@prsdthkr I've opened multiple issues in their repo asking them to work on their build times and they don't want to haha |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fix isCssModulesEnabled check when styles is undefined and improve setup in README
fixes #issueid