fix: Fix breaking datepicker test with merge #1240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skvale
changed the title
skvale
changed the title
jbadan
approved these changes
Oct 12, 2020
|
Check the deploy log for errors here: https://app.netlify.com/sites/fundamental-react/deploys Built with commit 0189d48 https://app.netlify.com/sites/fundamental-react/deploys/5f8473fc1551fc00085612d4 |
Has it been a problem before? My thought process was: "I should probably merge the latest in, but I don't want to wait another 4 hours for my build to finish" so, to me, the root-cause was painfully slow Travis builds |
|
@skvale Not sure what to tell you 🤷 We're trying to switch over to travis.com (waiting on red tape of course), but it's also going to be painfully slow as soon as those other repos that hog the builds move over there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix the failing build on the master branch after I merged the last PR
fixes #issueid