feat: new innerRefClassName prop as part of validationOverlayProps #1242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for fundamental-react ready! Built with commit 06b7f19 |
prsdthkr
reviewed
Oct 15, 2020
src/utils/_Popper.js
Outdated
| @@ -213,7 +213,7 @@ class Popper extends React.Component { | |||
| x-out-of-boundaries={isReferenceHidden ? 'true' : undefined} | |||
| // This is needed for fundamental-styles even though popper-2 uses data-placement as well | |||
| x-placement={placement}> | |||
| <div ref={innerRef}> | |||
| <div className={classnames(`${cssBlock}__innerRef`, popperProps?.innerRefClassName)} ref={innerRef}> | |||
There was a problem hiding this comment.
Should innerRefClassName be a separate prop? It doesn't seem to be a part of popper.js. Which is what we document popperProps as, right?
There was a problem hiding this comment.
Yeah, you're right... I'm not sure what I was thinking. Maybe I had popperProper and popoverProps confused 🤷♀️ I'll change this. Thanks!
jbadan
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is useful for passing an additional class from nui-widgets to the wrapper div inside popper.