Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Pull onClick off of props in pagination before spreading #748

Merged
merged 2 commits into from
Sep 17, 2019
Merged

fix: Pull onClick off of props in pagination before spreading #748

merged 2 commits into from
Sep 17, 2019

Conversation

skvale
Copy link
Contributor

@skvale skvale commented Sep 17, 2019

Description

onClick was being spread onto the container div and being called by each page.

fixes #747

@netlify
Copy link

netlify bot commented Sep 17, 2019 •
edited
Loading

Deploy preview for fundamental-react ready!

Built with commit c1e8ffa

https://deploy-preview-748--fundamental-react.netlify.com

jbadan
jbadan approved these changes Sep 17, 2019
View reviewed changes
Copy link
Contributor

@jbadan jbadan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once you update the failing snapshots, 🚢

@skvale skvale changed the title fix(pagination): Pull onClick off of props before spreading fix: Pull onClick off of props in pagination before spreading Sep 17, 2019
@jbadan jbadan merged commit a0adf25 into SAP:master Sep 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbadan jbadan jbadan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pagination: onClick event fired twice (once with invalid argument)
2 participants
@skvale @jbadan