chore: change main file path for bundlephobia #770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for fundamental-react ready! Built with commit 517c7ad |
hertweckhr1
approved these changes
Oct 15, 2019
|
I could see how this might fix publishing, but isn't the main entrypoint still Needs to study up more on package consumption |
|
@markpalfreeman I'll revert if it breaks anything :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I believe this change might fix the bundlephobia errors we've been having. Because we
cd libthennpm publish, there is nolib/index.js, justindex.js.I don't know how to test this besides merging and checking the build in bundlephobia 🤷♀
This might also fix the problem @parostatkiem had in codepen.
fixes #issueid