Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add check that all samples were tested #146

Merged
merged 2 commits into from
Sep 25, 2020
Merged

Conversation

ntnn
Copy link
Contributor

@ntnn ntnn commented Sep 25, 2020

Description

Adds a check in integration tests that all samples were actually checked.

I'd noticed that TestText didn't actually work correctly and added this additional check.
For the moment I've disabled the TestText test, we'll take care of that with the Uni* tests.

Related issues

Link any related issues here.

Tests

  • make lint
  • make test-go / make test-cgo
  • make integration-go / make integration-cgo

@ntnn ntnn requested a review from a team as a code owner September 25, 2020 07:26
@ntnn ntnn merged commit 7d66cee into SAP:master Sep 25, 2020
@ntnn ntnn deleted the check_samples_count branch September 25, 2020 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants