Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

newmanExecute: create collectionDisplayName inside of the step #207

Merged
merged 2 commits into from
Jul 13, 2018
Merged

newmanExecute: create collectionDisplayName inside of the step #207

merged 2 commits into from
Jul 13, 2018

Conversation

CCFenner
Copy link
Member

changes

  • move display name generation into the step
  • cleanup default

@CCFenner CCFenner self-assigned this Jul 12, 2018
@CCFenner CCFenner requested a review from rodibrin July 12, 2018 21:34
rodibrin
rodibrin approved these changes Jul 13, 2018
View reviewed changes
Copy link
Member

@rodibrin rodibrin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A documentation should be added

@CCFenner CCFenner merged commit 819f84f into master Jul 13, 2018
@CCFenner CCFenner deleted the CCFenner-patch-2 branch July 13, 2018 06:24
@CCFenner CCFenner mentioned this pull request Jul 13, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rodibrin rodibrin rodibrin approved these changes

Assignees

@CCFenner CCFenner

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CCFenner @rodibrin