Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flyout should close after click #1251

Merged
merged 5 commits into from
Apr 9, 2020
Merged

Flyout should close after click #1251

merged 5 commits into from
Apr 9, 2020

Conversation

marynaKhromova
Copy link
Contributor

@marynaKhromova marynaKhromova commented Apr 8, 2020 •
edited by maxmarkus

Fixes #1246

Fix for flyout when semiCollapsible mode

How to test:
Change test/e2e-test-application/src/luigi-config/extended/settings.js to
responsiveNavigation = 'simpleMobileOnly';

Add this to projectDetailNav.js nodes:

{
    category: {
      label: 'OMG',
      icon: '/assets/github-logo.png',
      collapsible: true
    },
    pathSegment: 'miscellaneous2',
    label: 'Miscellaneous2',
    viewUrl: '/sampleapp.html#/projects/' + projectId + '/miscellaneous2',
    icon: 'sys-help',
    openNodeInModal: true
  },
  {
    category: 'OMG',
    pathSegment: 'misc2-isolated',
    label: 'Miscellaneous2 (Isolated View)',
    isolateView: true,
    viewUrl: '/sampleapp.html#/projects/' + projectId + '/miscellaneous2',
    icon: 'sys-help-2'
  },

@marynaKhromova marynaKhromova added the bug Something isn't working label Apr 8, 2020
@marynaKhromova marynaKhromova added this to the Hardening v1.0 milestone Apr 8, 2020
@maxmarkus maxmarkus self-assigned this Apr 8, 2020
maxmarkus
maxmarkus approved these changes Apr 8, 2020
View reviewed changes
Copy link
Contributor

@maxmarkus maxmarkus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ndricimrr ndricimrr self-assigned this Apr 8, 2020
ndricimrr
ndricimrr approved these changes Apr 8, 2020
View reviewed changes
Copy link
Contributor

@ndricimrr ndricimrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works very well 👍

@marynaKhromova marynaKhromova merged commit d073132 into SAP:master Apr 9, 2020
JohannesDoberer added a commit to JohannesDoberer/luigi that referenced this pull request Apr 14, 2020
@JohannesDoberer
Merge branch 'master' into cache-improvements-for-dynamic-nodes
cc88e24 
* master: (28 commits)
  Move npm and other dependencies to devDependencies in core (SAP#1252)
  release 1.0.1 (SAP#1254)
  remove outdated code (SAP#1251)
  Fix GitHub security alerts (SAP#1248)
  Release CLI (SAP#1242)
  add faq question (SAP#1238)
  upgrade version of fundametal library styles, include sap fonts and icons, adjust html structure for fd-menu (SAP#1237)
  Mixed styles of note and tip in docu (SAP#1231)
  fix svelte example (SAP#1225)
  Add fromVirtualTreeRoot to linkManager (SAP#1226)
  add fromParent functionality (SAP#1222)
  Getting notified of unresponsive Luigi clients (SAP#1159)
  Optimize documentation for disableAutoLogin (SAP#1223)
  adjust html and css in fiddle after updating Fundamental Library version (SAP#1224)
  Update screenshots in docu (SAP#1218)
  use pushState instead of location.href for oidc (SAP#1213)
  Fix duplicate login logout buttons (SAP#1220)
  Replace docsearch cdn with npm package (SAP#1198)
  Security alerts fix (SAP#1208)
  Set focus on docu search input field (SAP#1196)
  ...
@marynaKhromova marynaKhromova deleted the 1246-Flyout-should-close-after-click branch April 17, 2020 15:42
JohannesDoberer added a commit to JohannesDoberer/luigi that referenced this pull request Apr 24, 2020
@JohannesDoberer
Merge branch 'master' into checkmarx-fix
f407c91 
* master: (39 commits)
  fixes zero innerwidth check which causes wrong semicollapsible mode (SAP#1291)
  update fundamental library in luigi core (SAP#1267)
  docu fix (SAP#1286)
  Added new fiddle test (SAP#1253)
  update fiddle to use luigi 1.0.1
  Update luigi-client-api.md
  updated code for auto routing experet scenario (SAP#1268)
  Fix leftnav nav-sync issue (SAP#1271)
  Fiddle demo page mobile view (SAP#1263)
  hide shellbar title for docu page
  docu page title fix (SAP#1279)
  Fix no-framework and react setup scripts (SAP#1250)
  run npm step only on tag starting with v (SAP#1255)
  Move npm and other dependencies to devDependencies in core (SAP#1252)
  release 1.0.1 (SAP#1254)
  remove outdated code (SAP#1251)
  Fix GitHub security alerts (SAP#1248)
  Release CLI (SAP#1242)
  add faq question (SAP#1238)
  upgrade version of fundametal library styles, include sap fonts and icons, adjust html structure for fd-menu (SAP#1237)
  ...
stanleychh pushed a commit to stanleychh/luigi that referenced this pull request Dec 30, 2021
@marynaKhromova @maxmarkus
remove outdated code (SAP#1251)
0e7aba4 
Co-authored-by: Markus <1720843+maxmarkus@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxmarkus maxmarkus maxmarkus approved these changes

@ndricimrr ndricimrr ndricimrr approved these changes

@alexandra-simeonova alexandra-simeonova Awaiting requested review from alexandra-simeonova

@hardl hardl Awaiting requested review from hardl hardl is a code owner

@JohannesDoberer JohannesDoberer Awaiting requested review from JohannesDoberer JohannesDoberer is a code owner

@pekura pekura Awaiting requested review from pekura

@zarkosimic zarkosimic Awaiting requested review from zarkosimic

Assignees

@maxmarkus maxmarkus

@ndricimrr ndricimrr

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Flyout should close after click
3 participants
@marynaKhromova @maxmarkus @ndricimrr