update fundamental library in luigi core #1267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marynaKhromova
requested review from
alexandra-simeonova,
hardl,
JohannesDoberer,
maxmarkus,
pekura and
zarkosimic
as code owners
…b.com:marynakhromova/luigi into 1227-Update-Fundamental-Library-in-luigi-core
UlianaMunich
approved these changes
Apr 17, 2020
JohannesDoberer
approved these changes
Apr 20, 2020
|
The mobile full-screen menu looks cropped on a mobile device (android).
|
|
@JohannesDoberer @UlianaMunich Guys, I would like you to check once more this PR. What has been done:
|
JohannesDoberer
approved these changes
Apr 22, 2020
JohannesDoberer
added a commit
to JohannesDoberer/luigi
that referenced
this pull request
Apr 24, 2020
* master: (39 commits) fixes zero innerwidth check which causes wrong semicollapsible mode (SAP#1291) update fundamental library in luigi core (SAP#1267) docu fix (SAP#1286) Added new fiddle test (SAP#1253) update fiddle to use luigi 1.0.1 Update luigi-client-api.md updated code for auto routing experet scenario (SAP#1268) Fix leftnav nav-sync issue (SAP#1271) Fiddle demo page mobile view (SAP#1263) hide shellbar title for docu page docu page title fix (SAP#1279) Fix no-framework and react setup scripts (SAP#1250) run npm step only on tag starting with v (SAP#1255) Move npm and other dependencies to devDependencies in core (SAP#1252) release 1.0.1 (SAP#1254) remove outdated code (SAP#1251) Fix GitHub security alerts (SAP#1248) Release CLI (SAP#1242) add faq question (SAP#1238) upgrade version of fundametal library styles, include sap fonts and icons, adjust html structure for fd-menu (SAP#1237) ...
JohannesDoberer
added a commit
to JohannesDoberer/luigi
that referenced
this pull request
Apr 24, 2020
stanleychh
pushed a commit
to stanleychh/luigi
that referenced
this pull request
Dec 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
fundamentalStyleClasses.js(include/exclude needed styles)@sap-theming/theming-base-contentUpdate:
I also extracted the common CSS variables into a separate file
_variables.scssFixes #1227