Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix leftnav nav-sync issue #1271

Merged
merged 9 commits into from Apr 21, 2020

Conversation

maxmarkus
Copy link
Contributor

Fixes #1258

@maxmarkus maxmarkus added the bug Something isn't working label Apr 16, 2020
@maxmarkus maxmarkus added this to the Sprint 10 milestone Apr 16, 2020
@zarkosimic zarkosimic self-assigned this Apr 16, 2020
@JohannesDoberer JohannesDoberer self-assigned this Apr 17, 2020
Copy link
Contributor

@zarkosimic zarkosimic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

@JohannesDoberer JohannesDoberer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@maxmarkus maxmarkus merged commit 001afcb into SAP:master Apr 21, 2020
@maxmarkus maxmarkus deleted the 1258-fix-leftnav-navsync-issue branch April 21, 2020 09:47
JohannesDoberer added a commit to JohannesDoberer/luigi that referenced this pull request Apr 24, 2020
* master: (39 commits)
  fixes zero innerwidth check which causes wrong semicollapsible mode (SAP#1291)
  update fundamental library in luigi core (SAP#1267)
  docu fix (SAP#1286)
  Added new fiddle test (SAP#1253)
  update fiddle to use luigi 1.0.1
  Update luigi-client-api.md
  updated code for auto routing experet scenario (SAP#1268)
  Fix leftnav nav-sync issue (SAP#1271)
  Fiddle demo page mobile view (SAP#1263)
  hide shellbar title for docu page
  docu page title fix (SAP#1279)
  Fix no-framework and react setup scripts (SAP#1250)
  run npm step only on tag starting with v (SAP#1255)
  Move npm and other dependencies to devDependencies in core (SAP#1252)
  release 1.0.1 (SAP#1254)
  remove outdated code (SAP#1251)
  Fix GitHub security alerts (SAP#1248)
  Release CLI (SAP#1242)
  add faq question (SAP#1238)
  upgrade version of fundametal library styles, include sap fonts and icons, adjust html structure for fd-menu (SAP#1237)
  ...
This was referenced Apr 24, 2020
stanleychh pushed a commit to stanleychh/luigi that referenced this pull request Dec 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The Nav Sync doesn't sync with micro frontend links
3 participants