Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move npm and other dependencies to devDependencies in core #1252

Merged

Conversation

zarkosimic
Copy link
Contributor

Fixes #1235

@zarkosimic zarkosimic added the refactoring Something needs to be refactored in a separate task label Apr 8, 2020
@zarkosimic zarkosimic added this to the Hardening v1.0 milestone Apr 8, 2020
@ndricimrr ndricimrr self-assigned this Apr 8, 2020
@marynaKhromova marynaKhromova self-assigned this Apr 9, 2020
Copy link
Contributor

@ndricimrr ndricimrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@JohannesDoberer JohannesDoberer merged commit 783a904 into SAP:master Apr 14, 2020
@zarkosimic zarkosimic deleted the 1235_move_npm_to_devDependencies_in_core branch April 14, 2020 09:04
JohannesDoberer added a commit to JohannesDoberer/luigi that referenced this pull request Apr 14, 2020
* master: (28 commits)
  Move npm and other dependencies to devDependencies in core (SAP#1252)
  release 1.0.1 (SAP#1254)
  remove outdated code (SAP#1251)
  Fix GitHub security alerts (SAP#1248)
  Release CLI (SAP#1242)
  add faq question (SAP#1238)
  upgrade version of fundametal library styles, include sap fonts and icons, adjust html structure for fd-menu (SAP#1237)
  Mixed styles of note and tip in docu (SAP#1231)
  fix svelte example (SAP#1225)
  Add fromVirtualTreeRoot to linkManager (SAP#1226)
  add fromParent functionality (SAP#1222)
  Getting notified of unresponsive Luigi clients (SAP#1159)
  Optimize documentation for disableAutoLogin (SAP#1223)
  adjust html and css in fiddle after updating Fundamental Library version (SAP#1224)
  Update screenshots in docu (SAP#1218)
  use pushState instead of location.href for oidc (SAP#1213)
  Fix duplicate login logout buttons (SAP#1220)
  Replace docsearch cdn with npm package (SAP#1198)
  Security alerts fix (SAP#1208)
  Set focus on docu search input field (SAP#1196)
  ...
JohannesDoberer added a commit to JohannesDoberer/luigi that referenced this pull request Apr 24, 2020
* master: (39 commits)
  fixes zero innerwidth check which causes wrong semicollapsible mode (SAP#1291)
  update fundamental library in luigi core (SAP#1267)
  docu fix (SAP#1286)
  Added new fiddle test (SAP#1253)
  update fiddle to use luigi 1.0.1
  Update luigi-client-api.md
  updated code for auto routing experet scenario (SAP#1268)
  Fix leftnav nav-sync issue (SAP#1271)
  Fiddle demo page mobile view (SAP#1263)
  hide shellbar title for docu page
  docu page title fix (SAP#1279)
  Fix no-framework and react setup scripts (SAP#1250)
  run npm step only on tag starting with v (SAP#1255)
  Move npm and other dependencies to devDependencies in core (SAP#1252)
  release 1.0.1 (SAP#1254)
  remove outdated code (SAP#1251)
  Fix GitHub security alerts (SAP#1248)
  Release CLI (SAP#1242)
  add faq question (SAP#1238)
  upgrade version of fundametal library styles, include sap fonts and icons, adjust html structure for fd-menu (SAP#1237)
  ...
stanleychh pushed a commit to stanleychh/luigi that referenced this pull request Dec 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Something needs to be refactored in a separate task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Investigate if we can move npm and other depenedencies to devDependencies in core
4 participants