Fix splitview closing #3571
Merged
Fix splitview closing #3571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camelCaseChris
requested review from
alexandra-simeonova,
hardl,
JohannesDoberer,
ndricimrr and
VincentUllal
as code owners
ndricimrr
reviewed
Dec 8, 2023
test/e2e-test-application/cypress/e2e/tests/1-angular/navigation-4.cy.js
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request:
I could not reproduce the bug, behavior on my side was as expected: closing the modal did not close the split view. Maybe the issue was fixed by some other change in the meantime.
In any case, I added a test to make sure that this does not happen again in the future.
Related issue(s)
Fixes #3361.