Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate docs to svelte4 #3581

Merged
merged 16 commits into from
Dec 14, 2023
Merged

Migrate docs to svelte4 #3581

merged 16 commits into from
Dec 14, 2023

Conversation

camelCaseChris
Copy link
Contributor

Description

Changes proposed in this pull request:

  • Upgrade from Svelte 3 to Svelte 4.
  • Bump of other dependencies that are directly or indirectly related to Svelte(Kit).
  • Changes to tsconfig to remove warnings and errors. Included upgrade from TS 4 to TS 5.

Comments/concerns:

  • I cleaned up unused SvelteKit adapters, including the one for Netlify. This works locally but we should check if the deployment of the site is somehow impacted by this.
  • At one point it was not possible to update (or even delete) dependencies one by one because of looping conflicts in peer dependencies. The only way I could fix that was by deleting package-lock.json and node_modules, bulk-change package.json and then do npm install again. If you run into any issues when doing a regular npm install, doing npm ci might be needed.
  • I kept getting several kinds or warnings and errors around tsconfig.json. After several changes it now looks a lot different. With the current state, npm run check works fine as well as the build, core and client scripts. tsconfig.json uses the generated config file of SvelteKit again. With the bumps to SvelteKit and TS, running npm client once will make some updates to that generated config file.

Not included:

  • Bump of other dependencies.

Related issue(s)

Fixes #3574.

It is already included in SvelteKit
@ndricimrr ndricimrr self-assigned this Dec 12, 2023
Copy link
Contributor

@ndricimrr ndricimrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and working as expected.

@ndricimrr ndricimrr changed the title 3574 migrate docs to svelte4 Migrate docs to svelte4 Dec 13, 2023
@camelCaseChris
Copy link
Contributor Author

Test deployment seems to have worked fine. Link to the test deployment is available in the list of checks.

Copy link
Contributor

@ndricimrr ndricimrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deployed Site looks good too 👍

@camelCaseChris camelCaseChris merged commit 01e7517 into main Dec 14, 2023
12 checks passed
@camelCaseChris camelCaseChris deleted the 3574-migrate-docs-to-svelte4 branch December 14, 2023 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate docs to Svelte 4
2 participants