-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate docs to svelte4 #3581
Migrate docs to svelte4 #3581
Conversation
It is already included in SvelteKit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and working as expected.
Test deployment seems to have worked fine. Link to the test deployment is available in the list of checks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Deployed Site looks good too 👍
Description
Changes proposed in this pull request:
Comments/concerns:
npm install
again. If you run into any issues when doing a regularnpm install
, doingnpm ci
might be needed.npm run check
works fine as well as thebuild
,core
andclient
scripts. tsconfig.json uses the generated config file of SvelteKit again. With the bumps to SvelteKit and TS, runningnpm client
once will make some updates to that generated config file.Not included:
Related issue(s)
Fixes #3574.