Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix split view sizing with BTP layout #3655

Merged
merged 4 commits into from
Feb 22, 2024
Merged

Fix split view sizing with BTP layout #3655

merged 4 commits into from
Feb 22, 2024

Conversation

camelCaseChris
Copy link
Contributor

Description

Changes proposed in this pull request:

  • Fix split view container/dragger being sized incorrectly. Background: the split view is positioned absolutely, with a left offset set to the width of the left navigation. There is no positioned element between the split view and the root element, so the offset is relative to the root. In BTP mode, the vertical navigation is also positioned, so the offset is then wrong. It has to be 0 instead.
  • New test for the above change. Proposing a new test file for the E2E JS tests, assuming that there will be more tests for the BTP layout.

Related issue(s)
Fixes #3639

@JohannesDoberer JohannesDoberer self-assigned this Feb 20, 2024
JohannesDoberer
JohannesDoberer approved these changes Feb 22, 2024
View reviewed changes
Copy link
Contributor

@JohannesDoberer JohannesDoberer left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 !

@camelCaseChris camelCaseChris merged commit 0613d51 into main Feb 22, 2024
12 checks passed
@camelCaseChris camelCaseChris deleted the 3639-btp-splitview branch February 22, 2024 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohannesDoberer JohannesDoberer JohannesDoberer approved these changes

@hardl hardl Awaiting requested review from hardl hardl is a code owner

@ndricimrr ndricimrr Awaiting requested review from ndricimrr ndricimrr is a code owner

@VincentUllal VincentUllal Awaiting requested review from VincentUllal VincentUllal is a code owner

Assignees

@JohannesDoberer JohannesDoberer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix splitview calculation and add Cypress test Splitview size check
2 participants
@camelCaseChris @JohannesDoberer