-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore/eslint return type #2252
chore/eslint return type #2252
Conversation
🦋 Changeset detectedLatest commit: 9ab744c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Configuration for code and tests lg
- Updates to
create
package lg - Changeset provided
- Did not test manually
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
code changes ok
changeset ok
did NOT test manually
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding eslint rule looks good.
changeset ✅
* origin/main: chore: apply latest changesets fix: regression with 'UIDefaultButton' - expand icon is applied even there no submenu (#2257) chore: apply latest changesets fix(ui-prompting): remove left margin when in multi-columns view (#2256) chore: apply latest changesets Refactor error utils (#2253) chore(env-check) upgrade archiver 7.0.1 (#2255) chore: apply latest changesets chore/eslint return type (#2252)
"@typescript-eslint/explicit-function-return-type": "warn"
(onlysrc
, disabled fortest
folders)@sap-ux/create