Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore/eslint return type #2252

Merged
merged 7 commits into from
Aug 20, 2024
Merged

chore/eslint return type #2252

merged 7 commits into from
Aug 20, 2024

Conversation

tobiasqueck
Copy link
Contributor

  • adding rule "@typescript-eslint/explicit-function-return-type": "warn" (only src, disabled for test folders)
  • as example fix all new warnings in @sap-ux/create

@tobiasqueck tobiasqueck requested review from a team as code owners August 20, 2024 07:25
Copy link

changeset-bot bot commented Aug 20, 2024

🦋 Changeset detected

Latest commit: 9ab744c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sap-ux/create Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@johannes-kolbe johannes-kolbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Configuration for code and tests lg
  • Updates to create package lg
  • Changeset provided
  • Did not test manually

Copy link

sonarcloud bot commented Aug 20, 2024

Copy link
Contributor

@heimwege heimwege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

code changes ok
changeset ok
did NOT test manually

Copy link
Member

@devinea devinea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding eslint rule looks good.
changeset ✅

@tobiasqueck tobiasqueck merged commit a3cb772 into main Aug 20, 2024
13 checks passed
@tobiasqueck tobiasqueck deleted the chore/eslint-return-type branch August 20, 2024 12:33
devinea added a commit that referenced this pull request Aug 22, 2024
* origin/main:
  chore: apply latest changesets
  fix: regression with 'UIDefaultButton' - expand icon is applied even there no submenu (#2257)
  chore: apply latest changesets
  fix(ui-prompting): remove left margin when in multi-columns view (#2256)
  chore: apply latest changesets
  Refactor error utils (#2253)
  chore(env-check) upgrade archiver 7.0.1 (#2255)
  chore: apply latest changesets
  chore/eslint return type (#2252)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants