-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FPM writer: do not overwrite files #269
Conversation
🦋 Changeset detectedLatest commit: 9406ddd The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I have just two minor requests for improvements.
I didn't run the unit tests locally but the snapshot updates look correct and the CI test runs succeed, so I assume they are good.
Thanks, Tobias. |
Solves feature request #263.
All extension writers are enhanced so that they do not overwrite existing fragments, views, or controllers.
Instead, the given file is taken but the program continues and refers the existing file in the manifest.
New tests have been added for this scenario.
For further information please check the feature request.