-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consolidate templates for Fiori elements FPM #39
Conversation
@nlunets I noticed that in the FPM explorer you add custom pages as components to a Fiori elements application, however, when using the page modeler in the SAP Fiori tools, custom pages are added as views. @Klaus-Keller FYI |
The recommendation would be to add them as components as this enables the usage of building blocks inside the custom page :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall it looks good (simple but good).
I'm wondering if we should add more details / options (like how to extend controller extensions and the like in the controller)
Small comments to change
packages/templates/fev4-fpm/templates/page/ext/NAME/Controller.js
Outdated
Show resolved
Hide resolved
@nlunets, what is the minimum UI5 version this template can be used? |
I would say 1.93 |
@nlunets
Main explanation was that |
🦋 Changeset detectedLatest commit: daddfd3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK for me, but a merge from main
seems to be required
Before merging, I would need an approval for each of the following aspects
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good content wise
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tobiasqueck some comments included.
Thanks
Co-authored-by: Austin Devine <devinea@users.noreply.github.com>
Co-authored-by: Austin Devine <devinea@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @tobiasqueck lgtm and follow-up TBI created #170
The goal is to provide templates for adding custom extensions to a Fiori elements for OData v4 application that can be used in the SAP Fiori tools (in guided development as well as page modeler) that follow the guidelines provided in the Fiori elements flexible programming model explorer at https://ui5.sap.com/test-resources/sap/fe/core/fpmExplorer/index.html#/customElements/customElementsOverview
The current state is a draft implementation to get a better understanding what is needed for #73