Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix rule to match (user-supplied) keywords against log msg, paths, diff #330

Closed
wants to merge 1 commit into from

Conversation

copernico
Copy link
Contributor

No description provided.

@copernico
Copy link
Contributor Author

@sacca97 could you take a look? feel free to continue from here...

@sacca97
Copy link
Collaborator

sacca97 commented Oct 10, 2022

Do not merge. I just reworked that part to match the new features. Let's leave it open anyway for now.

@copernico
Copy link
Contributor Author

copernico commented Oct 10, 2022

With the code of this PR I did the following experiment: trying to get a useful report without specifying version intervals.

python client/cli/main.py CVE-2020-11997 --use-nvd --repository https://github.com/apache/guacamole-client --report html --use-backend optional --advisory-keywords=access,history,connection,user,visibility,addresses,permission

The fix is at relevance 14, with only two on top (relevance=15) due to the keyword "inject" in their log msg.

Seems promising.

Screenshot 2022-10-10 at 16 18 54

@copernico
Copy link
Contributor Author

I did not want to merge, just to make an experiment :-)

@copernico copernico closed this Oct 12, 2022
@copernico copernico deleted the keywords_matching_rules branch October 15, 2022 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants