Correct parsing of 'Nullable' attributes #102
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Codecov Report
@@ Coverage Diff @@
## master #102 +/- ##
==========================================
+ Coverage 92.23% 92.41% +0.17%
==========================================
Files 6 6
Lines 2434 2439 +5
==========================================
+ Hits 2245 2254 +9
+ Misses 189 185 -4
Continue to review full report at Codecov.
|
filak-sap
reviewed
Apr 29, 2020
homutov
force-pushed
the
nullable_properties
branch
from
ecf6518 to
bfa8ffa
Compare
Changes: - Consistent way of parsing bool attributes - Supports 'Nullable' attribute for properties (default: True) - Supports 'Nullable' attribute for function import parameters (default: False) Issue: SAP#98
homutov
force-pushed
the
nullable_properties
branch
from
bfa8ffa to
b595eca
Compare
|
Well done! Thank you very much indeed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Fixes #98