GH-8499: Apply code review improvements.

SAP · Oct 23, 2020 · a807b29 · a807b29
1 parent 6475ed9
commit a807b29
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 3 deletions.
diff --git a/feature-libs/organization/administration/core/model/augmented-core.model.ts b/feature-libs/organization/administration/core/model/augmented-core.model.ts
@@ -1,5 +1,8 @@
 import { Currency } from '@spartacus/core';
-import { B2BApprovalProcess } from './order-approval.model';
+import {
+  B2BApprovalProcess,
+  OrderApprovalPermissionResult,
+} from './order-approval.model';
 
 declare module '@spartacus/core' {
   interface B2BUnit {
@@ -23,6 +26,10 @@ declare module '@spartacus/core' {
   interface CostCenter {
     activeFlag?: boolean;
     currency?: Currency;
-    originalCode?: string; // TODO: validate the need of this
+    originalCode?: string;
+  }
+
+  interface Order {
+    permissionResults?: OrderApprovalPermissionResult[];
   }
 }
diff --git a/projects/core/src/model/order.model.ts b/projects/core/src/model/order.model.ts
@@ -147,7 +147,6 @@ export interface Order {
   orderDiscounts?: Price;
   orgCustomer?: B2BUser;
   paymentInfo?: PaymentDetails;
-  permissionResults?: any[]; //OrderApprovalPermissionResult[];
   pickupItemsQuantity?: number;
   pickupOrderGroups?: PickupOrderEntryGroup[];
   productDiscounts?: Price;