fix: i18n when using JSON in SSR - set reloadInterval: false
#15297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Platonn
changed the title
Platonn
changed the title
reloadInterval: false
|
Test summary
Run details
View run in Cypress Dashboard ➡️ Flakiness
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
||||||||||||||||||||||||||||||||||
Platonn
commented
Mar 7, 2022
znikola
approved these changes
Mar 7, 2022
Platonn
changed the title
reloadInterval: falsereloadInterval: false
Platonn
changed the title
reloadInterval: falsereloadInterval: false
Platonn
changed the title
reloadInterval: falsereloadInterval: false
Public API changes✔️ Nothing changed in analyzed entry points.
|
Platonn
added a commit
that referenced
this pull request
Mar 14, 2022
…ort to 4.3.x] (#15319) Previously, the periodical reloading of JSON assets in SSR was enabled by default by `i18next-http-backend`. The never-ending async task `setInterval()` invoked inside `i18next-http-backend` caused the SSR to hang. To prevent it, we're setting explicitly `reloadInterval: false` in the options of `i18next`. fixes #14372 it's a backport of PR #15297 to 4.3.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the periodical reloading of JSON translations in SSR was enabled by default by
i18next-http-backend. The never-ending async tasksetInterval()invoked insidei18next-http-backendcaused the SSR to hang.To prevent it, we're setting explicitly
reloadInterval: falsein the options ofi18next.fixes #14372