Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Organize imports in s4 service modules #19173

Merged
merged 2 commits into from
Aug 28, 2024
Merged

fix: Organize imports in s4 service modules #19173

merged 2 commits into from
Aug 28, 2024

Conversation

rmch91
Copy link
Contributor

@rmch91 rmch91 commented Aug 28, 2024

Duplicated imports where combined into one

@rmch91 rmch91 requested a review from a team as a code owner August 28, 2024 12:28
@github-actions github-actions bot marked this pull request as draft August 28, 2024 12:28
@rmch91 rmch91 marked this pull request as ready for review August 28, 2024 12:28
@github-actions GitHub Actions
Copy link
Contributor

Merge Checks Failed

Please push a commit to re-trigger the build. 
To push an empty commit you can use `git commit --allow-empty -m "Trigger Build"`

@github-actions github-actions bot marked this pull request as draft August 28, 2024 12:35
@rmch91 rmch91 marked this pull request as ready for review August 28, 2024 12:35
@cypress Cypress
Copy link

cypress bot commented Aug 28, 2024

spartacus    Run #44658

Run Properties:  status check passed Passed #44658  •  git commit 28905368db ℹ️: Merge a68a19e8c24f822b268ddcecace5bbb87465c9c7 into 07a6cce177a9cdadb82a5b0456ac...
Project spartacus
Branch Review organize-imports-in-s4-service
Run status status check passed Passed #44658
Run duration 03m 47s
Commit git commit 28905368db ℹ️: Merge a68a19e8c24f822b268ddcecace5bbb87465c9c7 into 07a6cce177a9cdadb82a5b0456ac...
Committer Roman
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 3
Tests that did not run due to a developer annotating a test with .skip  Pending 2
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 121
View all changes introduced in this branch ↗︎

@rmch91 rmch91 merged commit 780d582 into develop Aug 28, 2024
28 checks passed
@rmch91 rmch91 deleted the organize-imports-in-s4-service branch August 28, 2024 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pawelfras pawelfras pawelfras approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rmch91 @pawelfras