Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(a11y): Searchbox placeholder contrast issue #19193

Merged
merged 1 commit into from
Sep 10, 2024
Merged

fix(a11y): Searchbox placeholder contrast issue #19193

merged 1 commit into from
Sep 10, 2024

Conversation

sdrozdsap
Copy link
Contributor

@sdrozdsap sdrozdsap commented Sep 1, 2024 •
edited
Loading

@sdrozdsap sdrozdsap requested a review from a team as a code owner September 1, 2024 21:03
@github-actions github-actions bot marked this pull request as draft September 1, 2024 21:04
@sdrozdsap sdrozdsap marked this pull request as ready for review September 1, 2024 21:04
@cypress Cypress
Copy link

cypress bot commented Sep 1, 2024 •
edited
Loading

spartacus    Run #44787

Run Properties:  status check passed Passed #44787  •  git commit 2235f0ea91 ℹ️: Merge c55d21db27e6334b4863dc82aa20442062bee909 into 9134e71b8ffb6dea020fb12afe9e...
Project spartacus
Branch Review bugfix/CXSPA-1033
Run status status check passed Passed #44787
Run duration 11m 18s
Commit git commit 2235f0ea91 ℹ️: Merge c55d21db27e6334b4863dc82aa20442062bee909 into 9134e71b8ffb6dea020fb12afe9e...
Committer sdrozdsap
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 3
Tests that did not run due to a developer annotating a test with .skip  Pending 2
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 121
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎

@github-actions github-actions bot marked this pull request as draft September 10, 2024 10:30
@sdrozdsap sdrozdsap marked this pull request as ready for review September 10, 2024 10:30
@sdrozdsap sdrozdsap merged commit 8f6fa96 into develop Sep 10, 2024
28 checks passed
@sdrozdsap sdrozdsap deleted the bugfix/CXSPA-1033 branch September 10, 2024 11:55
Pio-Bar pushed a commit that referenced this pull request Sep 11, 2024
@sdrozdsap @Pio-Bar
fix(a11y): Searchbox placeholder contrast issue (#19193)
a0fd499
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zeyber Zeyber Zeyber approved these changes

@developpeurweb developpeurweb developpeurweb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sdrozdsap @Zeyber @developpeurweb