Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INTERNAL] Remove greenkeeper #49

Merged
merged 1 commit into from
Jul 6, 2018
Merged

[INTERNAL] Remove greenkeeper #49

merged 1 commit into from
Jul 6, 2018

Conversation

RandomByte
Copy link
Member

@RandomByte RandomByte commented Jul 5, 2018

And update package-lock.json which got weird with 000a6fe (EDIT: already done with #48, got removed from this commit)

@RandomByte RandomByte requested a review from matz3 July 5, 2018 13:52
@codeworrior
Copy link
Member

And update package-lock.json which got weird with 000a6fe

That's a question that I anyhow had: isn't there a way to check the package-lock.json for plausibility, either locally or as part of the Travis builds? I always felt uncomfortable when adding that file to a change as the diff usually was too big to understand it.

Maybe something like

  cp package-lock.json package-lock-candidate.json
  git checkout -f package-lock.json 
  npm install
  diff -U 3 package-lock-candidate.json package-lock.json

But maybe I just have to ban npm update from my mental toolkit and everything will be fine.

@RandomByte
Copy link
Member Author

@codeworrior This would make sense as part of the Travis build. I think the odd change in 000a6fe might have been caused by the usage of an older npm version.

But what's the purpose of git checkout -f package-lock.json?

@codeworrior
Copy link
Member

Well, that would work only locally before commit. Idea was to revert any local changes, let NPM recalculate the package-lock.json and check if there's anything unexpected in the diff.

@RandomByte
Copy link
Member Author

I created SAP/ui5-tooling#22 to track possible CI enhancements.

matz3
matz3 previously approved these changes Jul 6, 2018
@RandomByte RandomByte merged commit d0206ec into master Jul 6, 2018
@RandomByte RandomByte deleted the remove-greenkeeper branch July 6, 2018 08:12
@RandomByte
Copy link
Member Author

Also see SAP/ui5-logger#15 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants