Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui5 cli does not create source maps #472

Closed
matzetronic opened this issue Dec 15, 2020 · 2 comments
Closed

ui5 cli does not create source maps #472

matzetronic opened this issue Dec 15, 2020 · 2 comments
Labels
enhancement New feature or request

Comments

@matzetronic
Copy link

Hi,

we want to create a ui5 library using ui5 cli. The library is created including minified files and -dbg.js files but no source maps are created.

Expected Behavior

A js.map file should be created for each source file and minified sources should have a source mapping url pointing to the not minified source (-dgb.js) files.

Current Behavior

No source maps are created during "ui5 build".

Steps to Reproduce the Issue

run "ui5 build" in a ui5 library and inspect the build result.

Context

  • UI5 Module Version (output of ui5 --version when using the CLI): 2.6.6
  • Node.js Version: 10.22.0
  • npm Version: 6.14.6
  • OS/Platform: Mac OS 10.15.7
  • Browser (if relevant): unknown
  • Other information regarding your environment (optional): nothing
@matzetronic matzetronic added bug Something isn't working needs triage Needs to be investigated and confirmed as a valid issue that is not a duplicate labels Dec 15, 2020
RandomByte added a commit to SAP/ui5-builder that referenced this issue Dec 15, 2020
…aracters

The `slash` module does not convert "extended-length" paths or paths
which contain non-ASCII characters as documented in the modules README:
https://github.com/sindresorhus/slash/blob/7a9158487d8046c13f2de1db7e3734d33bdbb1bd/readme.md#slash-

Since in our case the resulting POSIX paths are only used in our virtual
fs "@ui5/fs", these limitations are not relevent to us.

Therefore we can simply replace any backslashes.

Related to SAP/ui5-fs#294
Resolves SAP/ui5-tooling#472
@RandomByte
Copy link
Member

RandomByte commented Dec 15, 2020

Hi and thanks for opening this issue 👋

Generating source maps is on our internal backlog and the heavy work has already been done in
SAP/ui5-builder#282.

However there are still some tricky questions on how to integrate this new build step in a well working and performant way. Also see https://github.com/SAP/ui5-builder/pull/282/files#r330896961

I am currently looking into refactoring parts of @ui5/project to improve the integration of such tasks. We hope to solve this soon as it also becomes critical for our internal switch of the production UI5 build to UI5 Tooling.

I'll leave this issue open so others can find it but I'll label it as a feature request 👍

PS: Please ignore PR 562 in the timeline above which mistakenly referenced this issue

@RandomByte RandomByte added enhancement New feature or request and removed bug Something isn't working needs triage Needs to be investigated and confirmed as a valid issue that is not a duplicate labels Dec 15, 2020
@RandomByte RandomByte changed the title ui5 cli does not create source maps? ui5 cli does not create source maps Dec 15, 2020
RandomByte added a commit to SAP/ui5-builder that referenced this issue Feb 23, 2022
Resolves SAP/ui5-tooling#472
Supersedes #282
Based on SAP/ui5-tooling#583
JIRA: CPOUI5FOUNDATION-434

Co-authored-by: Matthias Osswald <mat.osswald@sap.com>
@flovogt
Copy link
Member

flovogt commented Mar 20, 2023

Implemented with SAP/ui5-builder#695 and available as of v3.0.0

Thanks a lot @matzetronic for bringing this topic up.

@flovogt flovogt closed this as completed Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants