[FEATURE] replaceVersion/Copyright: Also process test-resources #693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JIRA: CPOUI5FOUNDATION-424
matz3
force-pushed
the
test-resources-replace-placeholders
branch
from
507da37
to
c340512
Compare
matz3
commented
Feb 11, 2022
| @@ -8,7 +8,7 @@ class ThemeLibraryBuilder extends AbstractBuilder { | |||
| workspace: resourceCollections.workspace, | |||
| options: { | |||
| copyright: project.metadata.copyright, | |||
| pattern: "/resources/**/*.{less,theme}" | |||
There was a problem hiding this comment.
Right now there's no need to extend the patterns for theme libraries. So this change should be reverted. Or what do you think?
There was a problem hiding this comment.
Yes, let's revert this for theme libraries. It's unlikely to be required for .less and .theme files in a theme's test-resources
RandomByte
reviewed
Feb 14, 2022
lib/types/library/LibraryBuilder.js
Outdated
| @@ -38,7 +38,7 @@ class LibraryBuilder extends AbstractBuilder { | |||
| workspace: resourceCollections.workspace, | |||
| options: { | |||
| version: project.version, | |||
| pattern: "/resources/**/*.{js,json,library,less,theme}" | |||
| pattern: "/**/*.{js,json,library,less,theme}" | |||
There was a problem hiding this comment.
Also add html extension here
RandomByte
approved these changes
Feb 14, 2022
matz3
added a commit
that referenced
this pull request
Mar 10, 2022
Follow-up of #693 There are use cases for a version placeholder in *.css files. This also adds some basic tests for placeholder replacements during a library build.
matz3
added a commit
that referenced
this pull request
Mar 10, 2022
Follow-up of #693 There are use cases for a version placeholder in *.css files. This also adds some basic tests for placeholder replacements during a library build.
matz3
added a commit
that referenced
this pull request
Mar 10, 2022
Follow-up of #693 There are use cases for a version placeholder in *.css files. This also adds some basic tests for placeholder replacements during a library build.
This was referenced Mar 30, 2022
Closed
This was referenced May 4, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: CPOUI5FOUNDATION-424