[INTERNAL] generateLibraryManifest: Ignore dependency resources #735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They should not be required to generate a manifest.json for a library project.
RandomByte
force-pushed
the
dep-less-library-manifest
branch
from
9e49506
to
877cef5
Compare
RandomByte
changed the title
matz3
reviewed
Apr 21, 2022
| @@ -12,23 +11,18 @@ const ReaderCollectionPrioritized = require("@ui5/fs").ReaderCollectionPrioritiz | |||
| * @alias module:@ui5/builder.tasks.generateLibraryManifest | |||
| * @param {object} parameters Parameters | |||
| * @param {module:@ui5/fs.DuplexCollection} parameters.workspace DuplexCollection to read and write files | |||
| * @param {module:@ui5/fs.AbstractReader} parameters.dependencies Reader or Collection to read dependency files | |||
There was a problem hiding this comment.
The parameter can also be removed within LibraryBuilder, right?
|
Good catch! I guess I initially assumed that the dependency resources might be needed to determine the version of library dependencies. But already in the initial PR, those versions have been determined from the project's metadata, not from resources in the dependencies. |
matz3
previously approved these changes
Apr 21, 2022
RandomByte
force-pushed
the
dep-less-library-manifest
branch
from
6d57a8b
to
5d7d060
Compare
matz3
approved these changes
Apr 21, 2022
This was referenced May 4, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They should not be required to generate a manifest.json for a library
project.