Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[INTERNAL] Minifier: Fix handling of input source maps of bundles #944

Merged
merged 2 commits into from
Oct 10, 2023
Merged

[INTERNAL] Minifier: Fix handling of input source maps of bundles #944

merged 2 commits into from
Oct 10, 2023

Commits on Oct 10, 2023

  1. [INTERNAL] Minifier: Fix handling of input source maps of bundles 

    Apparently there are known cases where projects execute a UI5 Tooling
build on a previous build result. In this case we will minify previously
created (and already minified) preload bundles.

The source maps associated with these bundles are index- (or "sectioned")
source maps. Some section maps (for example those generated during the
bundling) might be lacking the "names" array. Since this is fine for
regular source map, I assume this should be fine for index source maps
too. Apparently, Terser fails to parse these source maps as of today.
Therefore we will manually add the missing "names" array for the time
being.
    @RandomByte
    RandomByte committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    68a0147 View commit details
    Browse the repository at this point in the history

  2. [INTERNAL] Minifier: Improve test readability 

    Declare source maps as JSON instead of strings
    @RandomByte
    RandomByte committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    625b3fd View commit details
    Browse the repository at this point in the history