Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: environment for publishing #587

Merged
merged 1 commit into from
Mar 30, 2023
Merged

fix: environment for publishing #587

merged 1 commit into from
Mar 30, 2023
+2 −0

Conversation

vadson71
Copy link
Contributor

@vadson71 vadson71 commented Mar 30, 2023 •
edited
Loading

Environment variable added to npm deployment script

kranthie-sap
kranthie-sap approved these changes Mar 30, 2023
View reviewed changes
Copy link

@kranthie-sap kranthie-sap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change to the workflow looks good to me. It should skip the husky git hooks.

@sonarcloud
Copy link

sonarcloud bot commented Mar 30, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@vadson71 vadson71 merged commit 301f24c into master Mar 30, 2023
@vadson71 vadson71 deleted the publish-step-patch branch March 30, 2023 15:36
marufrasully pushed a commit that referenced this pull request Apr 3, 2023
@vadson71 @marufrasully
fix: environment for publishing (#587)
2b810e6
marufrasully pushed a commit that referenced this pull request Apr 3, 2023
@vadson71 @marufrasully
fix: environment for publishing (#587)
9aee188
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kranthie-sap kranthie-sap kranthie-sap approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vadson71 @kranthie-sap