feat: Detect usage of deprecated jQuery.sap API #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d3xter666
reviewed
Mar 14, 2024
RandomByte
previously approved these changes
Mar 14, 2024
So far, only the usage of global API such as `jQuery.sap` was detected. However, when using `jQuery` as local variable via a dependency, the usage of `jQuery.sap` was not detected, although all APIs within that namespace are deprecated.
matz3
force-pushed
the
jquery-sap-deprecation
branch
from
c7371f0
to
43215fa
Compare
RandomByte
approved these changes
Mar 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So far, only the usage of global API such as
jQuery.sapwas detected.However, when using
jQueryas local variable via a dependency, theusage of
jQuery.sapwas not detected, although all APIs within thatnamespace are deprecated.