Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Analyze sap.ui.core.Lib.init() call #33

Merged
merged 36 commits into from
Mar 25, 2024
Merged

feat: Analyze sap.ui.core.Lib.init() call #33

merged 36 commits into from
Mar 25, 2024

Conversation

d3xter666
Copy link
Contributor

@d3xter666 d3xter666 commented Mar 14, 2024 •
edited
Loading

JIRA: CPOUI5FOUNDATION-793

Adds checks whether Lib.init() has been called with apiVersion: 2 property.

@d3xter666 d3xter666 marked this pull request as draft March 15, 2024 07:10
@matz3 matz3 mentioned this pull request Mar 18, 2024
Closed
27 tasks
@d3xter666 d3xter666 requested a review from a team March 18, 2024 09:25
@d3xter666 d3xter666 marked this pull request as ready for review March 18, 2024 09:25
matz3
matz3 reviewed Mar 18, 2024
View reviewed changes
src/detectors/typeChecker/FileLinter.ts Outdated Show resolved Hide resolved
src/detectors/typeChecker/FileLinter.ts Outdated Show resolved Hide resolved
src/detectors/typeChecker/FileLinter.ts Outdated Show resolved Hide resolved
src/detectors/typeChecker/FileLinter.ts Outdated Show resolved Hide resolved
@d3xter666 d3xter666 force-pushed the lib-init-settings branch 2 times, most recently from 8226873 to 9838c34 Compare March 21, 2024 07:17
d3xter666 and others added 21 commits March 22, 2024 11:08
@d3xter666
feat: Analyze sap.ui.core.Lib.init() call
7b24c53
@d3xter666
fix: Eslint findings
32a3c65
@d3xter666
feat: Resolve lib dependency
d4c150c
@d3xter666
feat: Add tests
cc10209
@d3xter666
fix: Provide better ts types
4fa1096
@d3xter666
fix: Add docs and enhance tests
c310c64
@d3xter666
fix: Include only Lib's init() method into the analysis
03bb267
@d3xter666
fix: Update doc
bd50889
@d3xter666
fix: Eslint issues
7dbab5a
@d3xter666
fix: Eslint
c9d25a7
@d3xter666 @matz3
fix: Typos
eb087e0 
Co-authored-by: Matthias Oßwald <mat.osswald@sap.com>
@d3xter666 @matz3
fix: Typos
6444db0 
Co-authored-by: Matthias Oßwald <mat.osswald@sap.com>
@d3xter666
fix: Rename var
6dd8540
@d3xter666
refactor: Lib.init analyzer
7fcad3d
@d3xter666
fix: Lint & snapshots
6675826
@d3xter666
fix: Merge conflicts
8e99eb6
@matz3 @d3xter666
refactor: Check name of ModuleDeclaration instead of ImportDeclaration
882d220
@d3xter666
refactor: Better types for Lib.init() analyzer
64cda85
@d3xter666
fix: Eslint issues
0bbf0c4
@d3xter666
refactor: Tests
04d5304
@d3xter666
fix: Update test snapshots
75661bd
@d3xter666 d3xter666 requested review from matz3 and a team March 22, 2024 11:25
RandomByte
RandomByte requested changes Mar 22, 2024
View reviewed changes
src/detectors/typeChecker/FileLinter.ts Outdated Show resolved Hide resolved
src/detectors/typeChecker/FileLinter.ts Outdated Show resolved Hide resolved
src/detectors/typeChecker/FileLinter.ts Outdated Show resolved Hide resolved
src/detectors/typeChecker/FileLinter.ts Outdated Show resolved Hide resolved
@RandomByte
Copy link
Member

RandomByte commented Mar 22, 2024 •
edited
Loading

I benchmarked one of the recent commits from this branch against the latest commit from the main branch that this one is based on (linting sap.m on tag 1.120.10):

Commit Mean [s] Min [s] Max [s]
d313912 (main) 31.841 ± 0.415 31.198 32.597
13abc7f 32.714 ± 0.914 31.066 34.025

matz3
matz3 reviewed Mar 25, 2024
View reviewed changes
Copy link
Member

@matz3 matz3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@matz3 matz3 requested review from RandomByte and a team March 25, 2024 11:13
RandomByte
RandomByte approved these changes Mar 25, 2024
View reviewed changes
Copy link
Member

@RandomByte RandomByte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@d3xter666 d3xter666 merged commit 6d5bcdb into main Mar 25, 2024
7 checks passed
@d3xter666 d3xter666 deleted the lib-init-settings branch March 25, 2024 13:12
@openui5bot openui5bot mentioned this pull request Mar 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matz3 matz3 matz3 left review comments

@RandomByte RandomByte RandomByte approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@d3xter666 @RandomByte @matz3