Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Detect deprecated libs and components in manifest.json #34

Merged
merged 3 commits into from
Mar 19, 2024

Conversation

maxreichmann
Copy link
Member

  • Analyze dependencies within manifest.json
  • Add detections for deprecated libraries and components (manifest.json)
  • Add new reporter messages with ruleId's ui5-linter-no-deprecated-library and ui5-linter-no-deprecated-component
  • Update test snapshots

JIRA: CPOUI5FOUNDATION-807

@maxreichmann maxreichmann marked this pull request as draft March 15, 2024 11:55
@maxreichmann maxreichmann changed the title feat: Detect deprecated libs and components feat: Detect deprecated dependencies Mar 15, 2024
@matz3 matz3 mentioned this pull request Mar 18, 2024
27 tasks
This PR analyses dependencies within manifest.json and adds detections
for deprecated libraries and components.
This results in new reporter messages with ruleId's
ui5-linter-no-deprecated-library and ui5-linter-no-deprecated-component.
This PR also adds the corresponding test snapshots.

JIRA: CPOUI5FOUNDATION-807
@maxreichmann maxreichmann marked this pull request as ready for review March 19, 2024 14:40
@maxreichmann maxreichmann requested a review from a team March 19, 2024 14:40
@matz3 matz3 changed the title feat: Detect deprecated dependencies feat: Detect deprecated libs and components in manifest.json Mar 19, 2024
Copy link
Member

@matz3 matz3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maxreichmann maxreichmann merged commit 8aa74e1 into main Mar 19, 2024
7 checks passed
@maxreichmann maxreichmann deleted the 807-detect-deprecated-deps branch March 19, 2024 15:11
@openui5bot openui5bot mentioned this pull request Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants