Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Detect deprecations in ui5.yaml (in root directory) #39

Merged
merged 12 commits into from
Apr 17, 2024
Merged

feat: Detect deprecations in ui5.yaml (in root directory) #39

merged 12 commits into from
Apr 17, 2024
+832 −229

Conversation

maxreichmann
Copy link
Member

@maxreichmann maxreichmann commented Mar 19, 2024 •
edited
Loading

  • feat: Detect deprecated libs in any ui5.yaml with regards to its configuration schema
  • feat: Add support for multi-doc ui5.yaml
  • deps: Add data-with-position npm library for YAML-parsing (https://www.npmjs.com/package/data-with-position)
  • test: Add test for YamlLinter
  • test: Add ui5.yaml with deprecated libs to troublesome app
  • test: Add ui5.yaml with deprecated libs to NoDeprecatedApi rule test
  • refactor: Outsource list of deprecated libs to common utils constant

JIRA: CPOUI5FOUNDATION-822

@matz3 matz3 mentioned this pull request Mar 25, 2024
Closed
27 tasks
@maxreichmann maxreichmann force-pushed the analyze-ui5.yaml branch 2 times, most recently from de24d88 to aecf1d3 Compare April 10, 2024 12:31
@maxreichmann maxreichmann marked this pull request as ready for review April 10, 2024 12:31
@maxreichmann maxreichmann marked this pull request as draft April 11, 2024 07:46
@maxreichmann maxreichmann marked this pull request as ready for review April 11, 2024 14:32
@flovogt flovogt force-pushed the analyze-ui5.yaml branch 3 times, most recently from d599ba2 to 3599d48 Compare April 12, 2024 16:15
@maxreichmann maxreichmann requested review from RandomByte and removed request for matz3, flovogt and RandomByte April 15, 2024 09:47
flovogt
flovogt previously approved these changes Apr 16, 2024
View reviewed changes
RandomByte
RandomByte requested changes Apr 16, 2024
View reviewed changes
Copy link
Member

@RandomByte RandomByte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall 💪

src/linter/yaml/UI5YamlLinter.ts Outdated Show resolved Hide resolved
src/linter/yaml/UI5YamlLinter.ts Outdated Show resolved Hide resolved
src/linter/yaml/UI5YamlLinter.ts Outdated Show resolved Hide resolved
src/linter/yaml/UI5YamlLinter.ts Outdated Show resolved Hide resolved
src/linter/yaml/UI5YamlLinter.ts Outdated Show resolved Hide resolved
test/fixtures/linter/rules/NoDeprecatedApi/ui5.yaml Show resolved Hide resolved
@maxreichmann maxreichmann marked this pull request as draft April 16, 2024 22:29
@maxreichmann maxreichmann marked this pull request as draft April 16, 2024 22:29
@maxreichmann maxreichmann marked this pull request as ready for review April 16, 2024 22:30
flovogt
flovogt previously approved these changes Apr 17, 2024
View reviewed changes
@flovogt flovogt requested a review from RandomByte April 17, 2024 12:14
@maxreichmann maxreichmann requested review from RandomByte and removed request for RandomByte April 17, 2024 12:44
RandomByte
RandomByte requested changes Apr 17, 2024
View reviewed changes
Copy link
Member

@RandomByte RandomByte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, just a nitpick

src/linter/yaml/YamlLinter.ts Outdated Show resolved Hide resolved
src/linter/yaml/YamlLinter.ts Outdated Show resolved Hide resolved
@flovogt flovogt requested a review from RandomByte April 17, 2024 13:57
@flovogt flovogt merged commit db118b1 into main Apr 17, 2024
16 checks passed
@flovogt flovogt deleted the analyze-ui5.yaml branch April 17, 2024 14:01
@openui5bot openui5bot mentioned this pull request Apr 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matz3 matz3 matz3 left review comments

@d3xter666 d3xter666 d3xter666 left review comments

@RandomByte RandomByte RandomByte approved these changes

@flovogt flovogt flovogt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@maxreichmann @matz3 @RandomByte @d3xter666 @flovogt