Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Detect pseudo modules #60

Merged
merged 33 commits into from
Apr 16, 2024
Merged

feat: Detect pseudo modules #60

merged 33 commits into from
Apr 16, 2024

Conversation

d3xter666
Copy link
Contributor

JIRA: CPOUI5FOUNDATION-821

@d3xter666 d3xter666 marked this pull request as draft April 4, 2024 13:49
@d3xter666 d3xter666 marked this pull request as ready for review April 10, 2024 12:18
@d3xter666 d3xter666 requested review from a team, matz3 and flovogt April 10, 2024 12:19
flovogt
flovogt requested changes Apr 12, 2024
View reviewed changes
scripts/metadataProvider/createPseudoModulesInfo.ts Outdated Show resolved Hide resolved
scripts/metadataProvider/createPseudoModulesInfo.ts Outdated Show resolved Hide resolved
scripts/metadataProvider/createPseudoModulesInfo.ts Outdated Show resolved Hide resolved
scripts/metadataProvider/createPseudoModulesInfo.ts Outdated Show resolved Hide resolved
scripts/metadataProvider/createPseudoModulesInfo.ts Outdated Show resolved Hide resolved
scripts/metadataProvider/createPseudoModulesInfo.ts Outdated Show resolved Hide resolved
scripts/metadataProvider/createPseudoModulesInfo.ts Outdated Show resolved Hide resolved
matz3
matz3 reviewed Apr 15, 2024
View reviewed changes
src/linter/ui5Types/SourceFileLinter.ts Outdated Show resolved Hide resolved
src/linter/ui5Types/SourceFileLinter.ts Outdated Show resolved Hide resolved
scripts/metadataProvider/createPseudoModulesInfo.ts Outdated Show resolved Hide resolved
matz3
matz3 reviewed Apr 15, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
flovogt
flovogt previously approved these changes Apr 16, 2024
View reviewed changes
@flovogt flovogt self-requested a review April 16, 2024 07:59
@flovogt flovogt dismissed their stale review April 16, 2024 07:59

datatypes are missing

@d3xter666 d3xter666 merged commit 508d81d into main Apr 16, 2024
16 checks passed
@d3xter666 d3xter666 deleted the detect-pseudo-modules branch April 16, 2024 12:01
@openui5bot openui5bot mentioned this pull request Apr 16, 2024
Merged
RandomByte
RandomByte requested changes Apr 16, 2024
View reviewed changes
Copy link
Member

@RandomByte RandomByte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the late review

README.md Show resolved Hide resolved
package.json Show resolved Hide resolved
scripts/metadataProvider/helpers.ts Show resolved Hide resolved
scripts/metadataProvider/createPseudoModulesInfo.ts Show resolved Hide resolved
@matz3 matz3 mentioned this pull request Apr 17, 2024
Closed
27 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matz3 matz3 matz3 left review comments

@KlattG KlattG KlattG left review comments

@RandomByte RandomByte RandomByte requested changes

@flovogt flovogt flovogt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@d3xter666 @matz3 @RandomByte @flovogt @KlattG