Update coverage thresholds / Add comment

SAP · Mar 24, 2020 · c8aab6d · c8aab6d
1 parent c258bfd
commit c8aab6d
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 6 deletions.
diff --git a/lib/projectPreprocessor.js b/lib/projectPreprocessor.js
@@ -422,6 +422,7 @@ class ProjectPreprocessor {
 
 		const validationResults = await Promise.all(
 			configs.map(async (config, documentIndex) => {
+				// Catch validation errors to ensure proper order of rejections within Promise.all
 				try {
 					await validate({
 						config,

diff --git a/test/lib/validation/schema/specVersion/2.0/kind/project/module.js b/test/lib/validation/schema/specVersion/2.0/kind/project/module.js
@@ -26,10 +26,10 @@ test.before((t) => {
 test.after.always((t) => {
 	t.context.ajvCoverage.createReport("html", {dir: "coverage/ajv-project-module"});
 	const thresholds = {
-		statements: 25,
-		branches: 20,
+		statements: 65,
+		branches: 55,
 		functions: 100,
-		lines: 25
+		lines: 65
 	};
 	t.context.ajvCoverage.verify(thresholds);
 });

diff --git a/test/lib/validation/schema/ui5.js b/test/lib/validation/schema/ui5.js
@@ -26,10 +26,10 @@ test.before((t) => {
 test.after.always((t) => {
 	t.context.ajvCoverage.createReport("html", {dir: "coverage/ajv-ui5"});
 	const thresholds = {
-		statements: 58,
-		branches: 50,
+		statements: 95,
+		branches: 80,
 		functions: 100,
-		lines: 58
+		lines: 95
 	};
 	t.context.ajvCoverage.verify(thresholds);
 });