Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skip empty resources and serve them as 404 #40

Merged
merged 2 commits into from
Jul 14, 2018
Merged

Conversation

MichaelSp
Copy link
Member

fixes #39

Signed-off-by: Michael Sprauer Michael.Sprauer@sap.com

Signed-off-by: Michael Sprauer <Michael.Sprauer@sap.com>
@coveralls
Copy link

coveralls commented Jul 13, 2018

Pull Request Test Coverage Report for Build 164

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.7%) to 73.834%

Files with Coverage Reduction New Missed Lines %
lib/middleware/serveIndex.js 1 78.05%
Totals Coverage Status
Change from base Build 159: 0.7%
Covered Lines: 259
Relevant Lines: 331

💛 - Coveralls

Signed-off-by: Michael Sprauer <Michael.Sprauer@sap.com>
Copy link
Contributor

@petermuessig petermuessig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for your fix... 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

missing files are served by index with HTTP 200
3 participants