Merge remote-tracking branch 'origin/main' into refactor/filter-group…

…-item
SAP · Jul 5, 2024 · 8926a08 · 8926a08
2 parents 748b8a5 + 10e50a2
commit 8926a08
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 7 deletions.
diff --git a/docs/MigrationGuide.mdx b/docs/MigrationGuide.mdx
@@ -502,6 +502,14 @@ function MyComponent() {
 
 ```
 
+### ObjectPageSection
+
+The prop `titleText` is now required and the default value `true` has been removed for the `titleTextUppercase` prop to comply with the updated Fiori design guidelines.
+
+### ObjectPageSubSection
+
+The prop `titleText` is now required.
+
 ## Enum Changes
 
 For a better alignment with the UI5 Web Components, the following enums have been renamed:

diff --git a/packages/main/src/components/ObjectPage/ObjectPage.cy.tsx b/packages/main/src/components/ObjectPage/ObjectPage.cy.tsx
@@ -729,7 +729,7 @@ describe('ObjectPage', () => {
     };
     cy.mount(<TestComp />);
 
-    cy.findByText('Lorem ipsum dolor sit amet').should('have.css', 'text-transform', 'uppercase');
+    cy.findByText('Lorem ipsum dolor sit amet').should('have.css', 'text-transform', 'none');
     cy.findByText('Etiam pellentesque').should('have.css', 'text-transform', 'none');
 
     cy.findByText('toggle uppercase').click();

diff --git a/packages/main/src/components/ObjectPageSection/index.tsx b/packages/main/src/components/ObjectPageSection/index.tsx
@@ -22,13 +22,11 @@ export interface ObjectPageSectionPropTypes extends CommonProps {
   /**
    * Defines the title of the `ObjectPageSection`.
    *
-   * @default ''
    */
-  titleText?: string;
+  titleText: string;
   /**
    * Defines whether the title is always displayed in uppercase.
    *
-   * @default true
    */
   titleTextUppercase?: boolean;
   /**
@@ -61,10 +59,10 @@ export interface ObjectPageSectionPropTypes extends CommonProps {
  */
 const ObjectPageSection = forwardRef<HTMLElement, ObjectPageSectionPropTypes>((props, ref) => {
   const {
-    titleText = '',
+    titleText,
     id,
     children,
-    titleTextUppercase = true,
+    titleTextUppercase,
     className,
     style,
     hideTitleText,

diff --git a/packages/main/src/components/ObjectPageSubSection/index.tsx b/packages/main/src/components/ObjectPageSubSection/index.tsx
@@ -22,7 +22,7 @@ export interface ObjectPageSubSectionPropTypes extends CommonProps {
   /**
    * Defines the title of the `ObjectPageSubSection`.
    */
-  titleText?: string;
+  titleText: string;
   /**
    * Actions available for this subsection.
    *